OKD-259: Add Validatation for the OKD Featureset to Prevent it From Being Enabled on OCP Clusters #10260
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jatinsu: This pull request references OKD-259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
commands I ran: go get github.com/openshift/api@latest go get github.com/openshift/client-go@latest go mod tidy go mod vendor
This check only allows the OKD featureset to be enabled in the install-config when the installer is compiled using `TAGS=scos hack/build.sh`
jatinsu
force-pushed
the
OKD-featuregates
branch
from
e971efd to
fccddc3
Compare
tthvo
left a comment
tthvo
left a comment
There was a problem hiding this comment.
/lgtm
Local testing worked as expected and unit tests also shows that.
$ go test -tags=scos -v -run "TestFeatureGates/OKD_featureset" ./pkg/types/validation/
=== RUN TestFeatureGates
=== RUN TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer
--- PASS: TestFeatureGates (0.00s)
--- PASS: TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer (0.00s)
PASS
ok github.com/openshift/installer/pkg/types/validation 0.021s
$ go test -v -run "TestFeatureGates/OKD_featureset" ./pkg/types/validation/
=== RUN TestFeatureGates
=== RUN TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer
--- PASS: TestFeatureGates (0.00s)
--- PASS: TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer (0.00s)
PASS
ok github.com/openshift/installer/pkg/types/validation 0.021s
|
/cc @patrickdillon |
|
@jatinsu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
3 participants
The newly introduced OKD feature set should not be enabled on OCP clusters. This PR introduces this and throws an error if a user has the OKD featureset enabled in the install-config and if the installer isn't compiled for scos (
TAGS=scos hack/build.sh)